Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/4829 #4837

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat/4829 #4837

wants to merge 7 commits into from

Conversation

Kolezhanchik
Copy link
Collaborator

No description provided.

@Kolezhanchik Kolezhanchik marked this pull request as draft February 3, 2025 23:47
@Kolezhanchik Kolezhanchik marked this pull request as ready for review February 4, 2025 17:32
@Kolezhanchik Kolezhanchik marked this pull request as draft February 4, 2025 21:32
@Kolezhanchik Kolezhanchik marked this pull request as ready for review February 4, 2025 22:04
@Kolezhanchik Kolezhanchik marked this pull request as draft February 4, 2025 23:01
Copy link

sonarqubecloud bot commented Feb 5, 2025

@Kolezhanchik Kolezhanchik marked this pull request as ready for review February 5, 2025 00:46
branches:
- main
paths:
- maintenance-mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename directory to maintenance

push:
branches:
- main
paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the changes on this action file?

- uses: actions/checkout@85e6279cec87321a52edac9c87bce653a07cf6c2

- name: Log in to GitHub Container Registry
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ${{ env.GITHUB_REGISTRY }} -u ${{ github.actor }} --password-stdin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really need?

- name: Display Image URL
run: |
echo "Image URL: ${{ env.IMAGE_NAME }}:${{ github.sha }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this for debugging?

@@ -0,0 +1,12 @@
FROM nginx:1.25.3-alpine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many break lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants