feat: 1580 list favorite activities for consep #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaopeng0202
requested review from
mgaseta,
DerekRoberts and
SLDonnelly
as code owners
xiaopeng0202
changed the title
xiaopeng0202
changed the title
mgaseta
requested changes
Dec 13, 2024
backend/src/main/java/ca/bc/gov/backendstartapi/dto/FavouriteActivityCreateDto.java
Outdated
Show resolved
Hide resolved
backend/src/main/resources/db/migration/V47__add_col_to_favourite_activity.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think the folder name should be all in lower case, to maintain the pattern we are using. And maybe a task for later, but now that we are starting CONSEP, we can try to re-arrange our project's folder organization.
We will miss the menu entry for now, only accessed by url |
mgaseta
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1580
Changelog
New
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: