Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HTML semantics #1742

Merged
merged 9 commits into from
Nov 28, 2024
Merged

feat: add HTML semantics #1742

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cedd9cf
feat: add HTML semantics
ngunner15 Nov 21, 2024
57239b5
fix: update alt text
ngunner15 Nov 21, 2024
a3a474a
Merge branch 'main' into feat/1722-wcag-standards-to-log-in-screen
ngunner15 Nov 21, 2024
7e376b8
fix: alt tag
ngunner15 Nov 22, 2024
5660f5b
fix: remove rule
ngunner15 Nov 25, 2024
415a1d8
Merge branch 'main' into feat/1722-wcag-standards-to-log-in-screen
ngunner15 Nov 25, 2024
ec69f4d
fix: remove role
ngunner15 Nov 26, 2024
b80587f
Merge branch 'main' into feat/1722-wcag-standards-to-log-in-screen
ngunner15 Nov 27, 2024
881e891
Merge branch 'main' into feat/1722-wcag-standards-to-log-in-screen
ngunner15 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion frontend/src/views/Landing/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ const Landing = () => {
statusQueries.filter((query) => query.status === 'error').length > 0
? (
<ActionableNotification
role="alert"
aria-live="assertive"
className="dependency-notification"
kind="warning"
lowContrast
Expand All @@ -58,6 +60,7 @@ const Landing = () => {
SPAR&apos;s service is impacted due to server connection issue.
You can check the&nbsp;
<Link
role="link"
target="_blank"
to="/service-status"
>
Expand Down Expand Up @@ -85,6 +88,8 @@ const Landing = () => {

{/* Login buttons */}
<Button
type="button"
role="button"
ngunner15 marked this conversation as resolved.
Show resolved Hide resolved
onClick={() => { signIn(LoginProviders.IDIR); }}
size="md"
renderIcon={Login}
Expand All @@ -95,6 +100,8 @@ const Landing = () => {
</Button>

<Button
type="button"
role="button"
kind="tertiary"
onClick={() => { signIn(LoginProviders.BCEID_BUSINESS); }}
size="md"
Expand All @@ -111,7 +118,7 @@ const Landing = () => {
<Column className="seeding-img-column" sm={4} md={3} lg={6}>
<img
src={Seeding}
alt="Small green seedling on the dirt and watered"
alt="Spruce tree branches with needles and cones"
className="seeding-img"
/>
</Column>
Expand Down
Loading