Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block navigation while in edit mode #1636

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Sep 24, 2024

Description

Closes #1635

Changelog

New

  • added useBlocker logic to seedlot review screen

Changed

  • None

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@craigyu craigyu self-assigned this Sep 24, 2024
@craigyu craigyu linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one question: after clicking on the save or discard option in the popup, shouldn't the user be redirected to where he wanted to go?

@RMCampos
Copy link
Contributor

Looking good, just one question: after clicking on the save or discard option in the popup, shouldn't the user be redirected to where he wanted to go?

That's a good question. But I'd say it's out of scope. User can click again, imo.

Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgaseta
Copy link
Collaborator

mgaseta commented Sep 26, 2024

Looking good, just one question: after clicking on the save or discard option in the popup, shouldn't the user be redirected to where he wanted to go?

That's a good question. But I'd say it's out of scope. User can click again, imo.

That makes sense, approving it then!

@RMCampos RMCampos merged commit e6bba8e into main Sep 26, 2024
24 of 26 checks passed
@RMCampos RMCampos deleted the fix/1635-patch-review-navigate-away-confirm-modal branch September 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch review navigate away confirm modal
3 participants