Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1594 adjustments for orchard screen #1599

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

ngunner15
Copy link
Collaborator

@ngunner15 ngunner15 commented Sep 5, 2024

Description

Closes #1594

Changelog

New

  • Make drop-down fields the same width

Changed

  • orchard cypress test(title and subtitle test)

Removed

  • plus/minus on the pollen breeding value field

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ngunner15 ngunner15 linked an issue Sep 5, 2024 that may be closed by this pull request
7 tasks
@ngunner15 ngunner15 self-assigned this Sep 5, 2024
@ngunner15 ngunner15 added front-end front-end related task test test related task labels Sep 5, 2024
@ngunner15 ngunner15 changed the title Feat/1594 adjustments for orchard screen feat: 1594 adjustments for orchard screen Sep 5, 2024
@mgaseta mgaseta marked this pull request as ready for review September 11, 2024 17:19
@mgaseta mgaseta self-assigned this Sep 11, 2024
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Good job Matheus and Nisarg!

@RMCampos
Copy link
Contributor

Have you pushed all the changes? When first getting into the page for an existing seedlot, the input is blank for me :(

image

@RMCampos RMCampos self-requested a review September 23, 2024 22:47
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still showing a blank orchard for me :(

@ngunner15 ngunner15 closed this Sep 23, 2024
@ngunner15 ngunner15 reopened this Sep 23, 2024
@RMCampos
Copy link
Contributor

Still showing a blank orchard for me :(

Testing on Incognito browsing mode it worked. Approved

@RMCampos RMCampos self-requested a review September 24, 2024 13:55
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgaseta mgaseta merged commit 62ff7b9 into main Sep 24, 2024
24 of 26 checks passed
@mgaseta mgaseta deleted the feat/1594-adjustments-for-orchard-screen branch September 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task test test related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustments for step 4 - Orchard screen
4 participants