Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add client id to concrete roles #1570

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

ngunner15
Copy link
Collaborator

@ngunner15 ngunner15 commented Aug 28, 2024

Description

Closes #1530

Changelog

New

  • Handling of roles with no client id

Changed

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ngunner15 ngunner15 added the back-end back-end related task label Aug 28, 2024
@ngunner15 ngunner15 linked an issue Aug 28, 2024 that may be closed by this pull request
@ngunner15 ngunner15 marked this pull request as ready for review August 28, 2024 19:16
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!
LGTM!

@craigyu craigyu merged commit 48ded19 into main Aug 29, 2024
23 of 25 checks passed
@craigyu craigyu deleted the fix/1530-look-at-roles-that-hasnt-any-client-id branch August 29, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end back-end related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look at ROLES that hasn't any CLIENT ID
3 participants