Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): run ETL on TEST and PROD in parallel, not series #1537

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix(ci): run ETL on TEST and PROD in parallel, not series #1537

merged 1 commit into from
Aug 20, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Aug 20, 2024 •
edited by github-actions bot
Loading

Description

Changelog

Changed

  • move environment calls to job, not step level
  • run TEST and PROD ETL in parallel, so TEST can't block PROD
  • ^ note: we want blocking eventually! ^

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

ronrobb
ronrobb approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ronrobb ronrobb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wing and a prayer

@DerekRoberts DerekRoberts self-assigned this Aug 20, 2024
@DerekRoberts DerekRoberts added back-end back-end related task devops devops related task bug Something isn't working and removed back-end back-end related task labels Aug 20, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review August 20, 2024 19:37
@DerekRoberts DerekRoberts merged commit 8a2f206 into main Aug 20, 2024
29 checks passed
@DerekRoberts DerekRoberts deleted the fix/ci/borkedETL branch August 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronrobb ronrobb ronrobb approved these changes

@craigyu craigyu Awaiting requested review from craigyu

@RMCampos RMCampos Awaiting requested review from RMCampos

@mgaseta mgaseta Awaiting requested review from mgaseta mgaseta is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@DerekRoberts DerekRoberts

Labels
bug Something isn't working devops devops related task
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerekRoberts @ronrobb