Skip to content

Commit

Permalink
fix: address pr comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Xiao Peng authored and Xiao Peng committed Jan 7, 2025
1 parent de82cd3 commit 97d998d
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
@Schema(description = "An object representing the request body when creating a favourite activity")
public record FavouriteActivityCreateDto(
@NotNull String activity,
@Schema(description = "Indicates whether this activity is a Consep", defaultValue = "false")
@Schema(description = "Indicates whether this activity is from Consep", defaultValue = "false")
Boolean isConsep) {}
2 changes: 1 addition & 1 deletion backend/src/main/resources/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ nr-spar-team-email-address = [email protected]

# Database, datasource and JPA
spring.datasource.driver-class-name = org.postgresql.Driver
spring.datasource.url = jdbc:postgresql://${POSTGRES_HOST:localhost}:5432/${POSTGRES_DB:postgres}
spring.datasource.url = jdbc:postgresql://${POSTGRES_HOST:localhost}:15432/${POSTGRES_DB:postgres}
spring.datasource.username = ${POSTGRES_USER:postgres}
spring.datasource.password = ${POSTGRES_PASSWORD:default}
spring.datasource.hikari.connectionTimeout = ${DB_POOL_CONN_TIMEOUT:90000}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ALTER TABLE
spar.favourite_activity
ADD
COLUMN is_consep BOOLEAN DEFAULT FALSE NOT NULL;
COLUMN is_consep BOOLEAN DEFAULT FALSE NOT NULL;
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,4 @@ services:
ORACLE_SYNC_USER: ${ORACLE_SYNC_USER:-proxy_fsa_spar_read_only_user}
depends_on:
database:
condition: service_started
condition: service_started
2 changes: 1 addition & 1 deletion frontend/src/components/FavouriteActivities/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface FavouriteActivitiesProps {
isConsep: boolean;
}

const FavouriteActivities: React.FC<FavouriteActivitiesProps> = ({ isConsep }) => {
const FavouriteActivities = ({ isConsep }: FavouriteActivitiesProps) => {
const windowSize = useWindowSize();

const favActQueryKey = ['favourite-activities'];
Expand Down

0 comments on commit 97d998d

Please sign in to comment.