feat: #659 support FOM for woodlot licensees #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianliuwk1019
commented
Jul 29, 2024
basilv
reviewed
Jul 30, 2024
basilv
reviewed
Jul 30, 2024
ianliuwk1019
commented
Jul 30, 2024
basilv
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #659
add migration script to include new project_plan_code table for "FSP" and "WOODLOT".
add migration script to include new columns for project table: "project_plan_code" and "woodlot_license_number" and index
app_fom.project (project_plan_code).default "project_plan_code" to value "FSP".
update ORM entities according to new migration script.
include "projectPlanCode" and "woodlotLicenseNumber" request fields and validations for creating new FOM at backend.
generate new api-client
add new input field "Type of Plan Holder" to select plan and its validation when creating/updating new FOM.
add new input field "woodlotLicenseNumber" when plan selected is "WOODLOT" and its validation when creating/updating new FOM .
make previous FSP input field as only required when plan selected is "FSP".
search result to include Woodlot License number at Plan Number column (previous FSP ID column)
adjust several pages for conditoinal displaying FSP ID or Woodlot License number.
fix affected existing tests.
adjust public frontend to conditionally display FSP # or Woodlot #
Asked question in ticket to confirm if there is existing Woodlot License Plan FOM(s) in production with FSP ID enters as some number but haven't gotten back reply yet. TODO: only when there is really such case, then need to include another migration to fix these particular FOM for correct project_plan and woodlot number from FSP ID column.
@basilv
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Once merged, code will be promoted and handed off to following workflow run.
b.com/bcgov/nr-fom/actions/workflows/merge-main.yml)
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Once merged, code will be promoted and handed off to following workflow run.