feat: Complaint details performance improvements #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayr974
reviewed
Jan 17, 2025
frontend/src/app/components/containers/complaints/details/complaint-details-edit.tsx
Outdated
Show resolved
Hide resolved
…Complaint call from outcome report child components
nayr974
reviewed
Jan 20, 2025
frontend/src/app/components/containers/complaints/list-items/complaint-action-items.tsx
Outdated
Show resolved
Hide resolved
…r-compliance-enforcement into CE-1332-comp-details-opt
mikevespi
changed the title
mikevespi
commented
Jan 21, 2025
frontend/src/app/components/containers/complaints/details/complaint-details-edit.tsx
Outdated
Show resolved
Hide resolved
|
nayr974
approved these changes
Jan 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Co-authored-by: Ryan Rondeau <[email protected]> Co-authored-by: Ryan Rondeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve load time of Complaint Details page.
Description
The complaint details page has several sections, each its own component. Each of these components was calling the case management API to fetch the case_file details, and setting them in the state. The responsibility of making that CM call was moved to the wrapping component so that it can be made once per page rather than once per section. This was done for the complaint-details-edit and the quick close modal.
Refactored selectComplaintDetails to use createSelector so it's not instantiating a new object every time triggering component effects.
Memoized a couple dynamically created objects.
Fixes # 1332
https://env-ceds.atlassian.net/jira/software/c/projects/CE/boards/4?selectedIssue=CE-1332
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: