feat: CE-1296 add Inspector and Province-wide roles #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayr974
reviewed
Jan 9, 2025
| @@ -32,7 +32,7 @@ let initialState: ComplaintFilters = { | |||
| outcomeAnimalEndDate: undefined, | |||
| }; | |||
|
|
|||
| const mapFilters = (complaintFilters: Partial<ComplaintFilters>) => { | |||
| const convertFilterNames = (complaintFilters: Partial<ComplaintFilters>) => { | |||
There was a problem hiding this comment.
Not that I oppose the change, but why?
There was a problem hiding this comment.
I'm guessing because it neither calls the map function nor has anything to do with the map in the application.
There was a problem hiding this comment.
^ It was me who named it map in the first place I think, but when I got in there this time it felt wrong. This feels like a more accurate name.
afwilcox
approved these changes
Jan 9, 2025
| @@ -32,7 +32,7 @@ let initialState: ComplaintFilters = { | |||
| outcomeAnimalEndDate: undefined, | |||
| }; | |||
|
|
|||
| const mapFilters = (complaintFilters: Partial<ComplaintFilters>) => { | |||
| const convertFilterNames = (complaintFilters: Partial<ComplaintFilters>) => { | |||
There was a problem hiding this comment.
I'm guessing because it neither calls the map function nor has anything to do with the map in the application.
|
nayr974
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the "Inspector" and "Province-wide" roles.
Description
Two new roles were added to the system in preparation for new users being onboarded. The Province-wide role has the default filter of "Open" and in the case of COS, will hide the "Zone at a glance" page. The Inspector role gets the default filters of "Open" and their assigned region. The "Zone at a glance" page is available to them.
Fixes # (issue)
How Has This Been Tested?
With a clear cache, I assigned the following roles to myself and verified that the appropriate default filters were applied on initial login, as well as when changing complaint types for COS. Zone at a glance being present or not was also verified, along with that the page shows the correct zone when present.
Checklist
Further comments
This PR also fixed what appeared to be a bug of CEEB users not getting the officer assigned as a default filter.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: