Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix pipeline pr into test #538

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

barrfalk
Copy link
Contributor

@barrfalk barrfalk commented Jul 18, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

{{- toYaml .Values.webeoc.podSecurityContext | nindent 12 }}
{{- end }}
containers:
- name: {{ include "webeoc.fullname" . }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZDIK5t0peGY0-TJaBa0-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_nr-compliance-enforcement&issues=AZDIK5t0peGY0-TJaBa0&open=AZDIK5t0peGY0-TJaBa0&pullRequest=538">SonarCloud</a></p>
cpu: 50m
memory: 100Mi
containers:
- name: {{ include "backend.fullname" . }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZDIK5v4peGY0-TJaBbA-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_nr-compliance-enforcement&issues=AZDIK5v4peGY0-TJaBbA&open=AZDIK5v4peGY0-TJaBbA&pullRequest=538">SonarCloud</a></p>
{{- toYaml .Values.frontend.podSecurityContext | nindent 12 }}
{{- end }}
containers:
- name: {{ include "frontend.fullname" . }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AZDIK5v-peGY0-TJaBbC-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_nr-compliance-enforcement&issues=AZDIK5v-peGY0-TJaBbC&open=AZDIK5v-peGY0-TJaBbC&pullRequest=538">SonarCloud</a></p>
@barrfalk barrfalk changed the base branch from main to release/pacific-spiny-lumpsucker July 18, 2024 23:28
Copy link

@barrfalk barrfalk merged commit 4503a1f into release/pacific-spiny-lumpsucker Jul 18, 2024
13 of 14 checks passed
@barrfalk barrfalk deleted the fit-pipeline-pr-into-test branch July 18, 2024 23:48
@barrfalk barrfalk restored the fit-pipeline-pr-into-test branch July 19, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants