Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-618 - Enable Actions Taken #518

Merged
merged 96 commits into from
Aug 21, 2024

Conversation

marqueone-ps
Copy link
Contributor

@marqueone-ps marqueone-ps commented Jul 12, 2024

Description

Adds the ability to see action-taken and action-taken-update in the complaint along side the complaint updates

Story # CE-618

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@Scarlett-Truong
Copy link
Collaborator

@marqueone-ps I've tested and it's working as expected when adding more actions 😃. However, there is an edge case I just want to highlight is when user add multiple actions within a short time (for ex: pic below I add action 1 &2 ), our app will only show the latest, which is action 2 and not showing action 1. I guess it's the edge case we cannot handle?
Screenshot 2024-08-14 at 5 24 25 PM
Screenshot 2024-08-14 at 5 25 46 PM

There're some small things that need your care in the PR:

  1. Update latest release branch and you may need to change the migration script version to V0.25.2
  2. Fix the added unit tests that are broken
  3. Remove console.log and commented code (there're some in the new push)
  4. Check SonarCloud issues here (including remove unused imports and some nested if)

Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all works perfectly as expected to me @marqueone-ps ✨✨. Just need some clean up for unused codes

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Scarlett-Truong Scarlett-Truong merged commit 5ea6581 into release/river-otter Aug 21, 2024
13 of 15 checks passed
@Scarlett-Truong Scarlett-Truong deleted the feature/CE-618 branch August 21, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants