Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code tables into single controller/service #189

Merged
merged 24 commits into from
Nov 11, 2023
Merged

Conversation

marqueone-ps
Copy link
Contributor

@marqueone-ps marqueone-ps commented Nov 5, 2023

Description

Refactor the existing individual code controller/service into a single controller/service

Task # CE-208

How Has This Been Tested?

New unit tests for code-table.controller and code-table.service

code-table.service

  • should return collection of agency codes
  • should return collection of attractant codes
  • should return collection of complaint status codes
  • should return collection of complaint type codes
  • should return collection of geo organization unit type codes
  • should return collection of nature of complaint codes
  • should return collection of person complaint codes
  • should return collection of species codes
  • should return collection of violation codes
  • should return collection of regions
  • should return collection of zones
  • should return collection of communities/areas

code-table.controller

  • should return 200 when a GET is called successfully
  • should return 404 when a requesting code table that doesn't exist

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Postman requests create for manually testing code-table controller

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.4% 17.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@afwilcox afwilcox disabled auto-merge November 11, 2023 01:09
@afwilcox afwilcox added this pull request to the merge queue Nov 11, 2023
Merged via the queue into main with commit b5fb4b7 Nov 11, 2023
15 of 16 checks passed
@afwilcox afwilcox deleted the refactor/CE-208 branch November 11, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants