CE-199-Refactoring of edit and geocoding functionality #181

barrfalk · 2023-10-28T19:40:20Z

Description

A number of changes were made here to improve the edit complaint location and geocoding functionality.

Refactored variable names to improve readability
Reduced minScore from 2 to 1 on geocoding since the geocoder was being overly picky on locality names and addresses.
Complaint coordinates are now displayed on edit screen
Updates the lat/lng values when the coordinates change so that the map reflects the latest and greatest coordinates

Fixes # CE-199

How Has This Been Tested?

Verified x and y coordinates are displayed on the edit screen
Verified saves to x and y coordinates are reflected on details map
Verified that "Pilot Mountain" and "Pilot Bay" which were previously not found by the geocoder are now found.
Verified that when the community changes the location on the map updates.
Verified that a user can create a complaint without a coordinate and that the map is centered based on the community name.
Verified that editing a complaint without coordinates and filling in the coordinates will correctly display the marker on the map at the entered coordinates.

Checklist

I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

A number of changes were made here to improve the edit complaint location and geocoding functionality. 1. Refactored variable names to improve readability 2. Reduced minScore from 2 to 1 on geocoding since the geocoder was being overly picky on locality names and addresses. 3. Complaint coordinates are now displayed on edit screen 4. Updates the lat/lng values when the coordinates change so that the map reflects the latest and greatest coordinates