Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GIR to case_code table #119

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat: Add GIR to case_code table #119

merged 1 commit into from
Jan 27, 2025

Conversation

mikevespi
Copy link
Contributor

@mikevespi mikevespi commented Jan 24, 2025

Add GIR case code.

Description

GIR complaints for the COS now have the additional notes section which counts as an outcome, and thus needs to exist in case management. This PR handles adding the GIR case code so that the cases can be created.

Fixes # 1138
https://env-ceds.atlassian.net/jira/software/c/projects/CE/boards/4?selectedIssue=CE-1138

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Additional notes were added to a GIR complaint via the NatCom application, and the case is succesfully created in CM then loaded back into NatCom appropriately

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Sibling branch in NatCom: bcgov/nr-compliance-enforcement#897


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@afwilcox afwilcox changed the title Add GIR to case_code table feat: Add GIR to case_code table Jan 24, 2025
@afwilcox afwilcox added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit c0affd0 Jan 27, 2025
9 checks passed
@afwilcox afwilcox deleted the CE-1138-gir-case-code branch January 27, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants