WFNEWS-2513 Text changes for response type description and title #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzlucas
approved these changes
Dec 17, 2024
| @@ -806,7 +806,9 @@ export function formatDate(timestamp: string | number): string { | |||
| }; | |||
|
|
|||
| return date.toLocaleDateString('en-US', options); | |||
| } else return ''; | |||
There was a problem hiding this comment.
should we throw an exception instead of a blank string?
There was a problem hiding this comment.
Yes, updated now
agordon-vivid
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text changes for response type description
Change title to "Response"
Remove secondary title