Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build number injection in ios and android pipeline #2139

Merged
merged 1 commit into from
Nov 7, 2024
Merged

add build number injection in ios and android pipeline #2139

merged 1 commit into from
Nov 7, 2024

Conversation

yzlucas
Copy link
Collaborator

@yzlucas yzlucas commented Nov 7, 2024

No description provided.

sukhpalp
sukhpalp requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@sukhpalp sukhpalp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cleaner to add a property to appConfig.mobile.json and update the job to replace the token in the file at build time.

On second thought, this is fine. If we are using this file on desktop too, then this is consistent.

@sukhpalp sukhpalp self-requested a review November 7, 2024 18:03
@yzlucas yzlucas merged commit f896db6 into bcgov:branch-2.4.0 Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssylver93 ssylver93 ssylver93 approved these changes

@sukhpalp sukhpalp sukhpalp approved these changes

@thefunkyhermit thefunkyhermit thefunkyhermit approved these changes

@agordon-vivid agordon-vivid Awaiting requested review from agordon-vivid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yzlucas @thefunkyhermit @sukhpalp @ssylver93