Allow credentials in cloudfront #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhpalp
added a commit
to sukhpalp/nr-bcws-wfnews
that referenced
this pull request
May 2, 2024
* set access_control_allow_credentials to true * remove CORS section entirely
sukhpalp
added a commit
to sukhpalp/nr-bcws-wfnews
that referenced
this pull request
May 2, 2024
* set access_control_allow_credentials to true * remove CORS section entirely
sukhpalp
added a commit
that referenced
this pull request
May 2, 2024
* Revert "Import fixes (#1881)" This reverts commit c17621d. * Revert "Fix typos (#1880)" This reverts commit db0f540. * Revert "Use corsfilter instead of bean (#1879)" This reverts commit b8e306b. * Revert "wfnews-2158: Missing url if bulletinUrl is null (#1878)" This reverts commit fe3099b. * Revert "Missing put pt2 (#1877)" This reverts commit 9381857. * Revert "Add put (#1876)" This reverts commit 97ab365. * Revert "Update CorsConfigurationSource (#1875)" This reverts commit 3b6e6b7. * Revert "Fix cors domains (#1874)" This reverts commit 1b9b93c. * Revert "Specify CORS settings (#1873)" This reverts commit 01ccd62. * Revert "Fix syntax for CORS (#1872)" This reverts commit d50a701. * Revert "Update CORS bean and call it in the CORS configuration (#1871)" This reverts commit 07e7109. * Revert "Remove redundant CORS implementations (#1870)" This reverts commit 270be8b. * Revert "Rollback CORS server changes (#1869)" This reverts commit b114cfc. * wfnews-2158: Missing url if bulletinUrl is null (#1878) * wfnews-2158 * wfnews-2158 * Backend only pipeline (#1882) * Fast build fix (#1883) * Backend only pipeline * Remove dependency to client * Allow credentials in cloudfront (#1884) * set access_control_allow_credentials to true * remove CORS section entirely --------- Co-authored-by: Lucas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.