Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wfnews 1515 #1165

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Wfnews 1515 #1165

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6570084
another approach on detect device magnometer
yzlucas Oct 6, 2023
f88b19d
Merge branch 'main' into wfnews-1515
yzlucas Oct 10, 2023
5da99ba
revert compass availablity check
yzlucas Oct 11, 2023
cb422d7
merge
yzlucas Oct 11, 2023
10fc586
compass supposed to be undefined without motion detector
yzlucas Oct 11, 2023
be4c572
compass supposed to be undefined without motion detector
yzlucas Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...main/angular/src/app/components/report-of-fire/compass-page/rof-compass-page.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,8 @@ initialize (data: any, index: number, reportOfFire: ReportOfFire) {
}

ngOnInit(): void {
// if ('AbsoluteOrientationSensor' in window && 'ontouchstart' in window) {
// // setup real compass thing
this.getOrientation();
this.useMyCurrentLocation();
// } else {
// // skip compass
// this.skip()
// }
}

async getOrientation() {
Expand Down Expand Up @@ -86,6 +80,10 @@ async getOrientation() {

handler(e, self) {
if (self.reportOfFire?.headingDetectionActive){
if (!e.alpha && !e.webkitCompassHeading){
this.skip()
}

try {
let compassHeading = e.webkitCompassHeading || Math.abs(e.alpha - 360);
compassHeading = Math.trunc(compassHeading)
Expand Down
Loading