Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFNEWS-1474, 1475, 1476, 1477, 1478, 1479, 1480, 1481, 1482, 1485: Wildfire List #1159

Merged
merged 21 commits into from
Oct 12, 2023

Conversation

dhlevi
Copy link
Collaborator

@dhlevi dhlevi commented Oct 10, 2023

Updates to wildfire List
Also includes additions for the other list view pages in 1475, 1476 and 1477
Also includes mobile screen additions for 1478, 1479, 1480, 1481

Filters page included for 1482, Search included for 1485

Removal of old current events component

@dhlevi dhlevi requested review from yzlucas and ssylver93 October 10, 2023 17:58
No implementation for Filters, Search by location at this point
@dhlevi dhlevi changed the title WFNEWS-1474, 1475, 1476, 1477: Wildfire List WFNEWS-1474, 1475, 1476, 1477, 1478, 1479, 1480, 1481: Wildfire List Oct 11, 2023
let whereString = ''

if (this.searchText && this.searchText.length > 0) {
whereString += `(EVENT_NAME LIKE '%${this.searchText}%' OR ORDER_ALERT_STATUS LIKE '%${this.searchText}%' OR ISSUING_AGENCY LIKE '%${this.searchText}%') AND (`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but could we maybe create a class and store these sql queries separetly? It may be hard to read/ maintain.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we are just putting these icons in place but not using them yet?

@dhlevi dhlevi changed the title WFNEWS-1474, 1475, 1476, 1477, 1478, 1479, 1480, 1481: Wildfire List WFNEWS-1474, 1475, 1476, 1477, 1478, 1479, 1480, 1481, 1482, 1485: Wildfire List Oct 12, 2023
@dhlevi dhlevi merged commit 86748dd into bcgov:main Oct 12, 2023
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:12 — with GitHub Actions Inactive
@dhlevi dhlevi deleted the wildfire-list branch October 12, 2023 21:18
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:24 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:24 — with GitHub Actions Inactive
@dhlevi dhlevi temporarily deployed to DEV October 12, 2023 21:24 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants