Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24298 Name-Examination UI - error occurred when selecting conflict or conflict selection has values #1550

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

eve-git
Copy link
Collaborator

@eve-git eve-git commented Nov 19, 2024

Issue #:
bcgov/entity#24298

Description of changes:
This is an update to the previous code change: the section for retrieving conflict business info from Entities has been commented out because:

  1. The corp number from Solr query result is in the COLIN format (without the BC prefix).
  2. The business query does not provide office and party information.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@eve-git
Copy link
Collaborator Author

eve-git commented Nov 19, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1550-2v6nlstm.web.app

@eve-git
Copy link
Collaborator Author

eve-git commented Nov 19, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1550-2v6nlstm.web.app

Copy link
Collaborator

@EPortman EPortman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eve-git eve-git merged commit 982429c into bcgov:main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants