feat: add error handling when updating NR data

bcgov · Aug 15, 2024 · 038580d · 038580d
1 parent 773bc1b
commit 038580d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/app/package.json b/app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "name-examination",
-  "version": "1.2.30",
+  "version": "1.2.31",
   "private": true,
   "scripts": {
     "build": "nuxt generate",

diff --git a/app/store/examine/index.ts b/app/store/examine/index.ts
@@ -817,15 +817,13 @@ export const useExamination = defineStore('examine', () => {
     // set reset flag so name data is managed between Namex and NRO correctly
     hasBeenReset.value = true
     await updateRequest()
-    await fetchAndLoadNr(nrNumber.value)
   }
 
   async function resetNr() {
     resetNrDecision()
     clearConsent()
     furnished.value = 'N'
     await updateRequest()
-    await fetchAndLoadNr(nrNumber.value)
   }
 
   async function claimNr() {
@@ -900,15 +898,18 @@ export const useExamination = defineStore('examine', () => {
   }
 
   async function updateRequest() {
-    const data = await getNrData()
-    const response = await putNameRequest(nrNumber.value, data)
-    if (response.ok) {
+    try {
+      const data = await getNrData()
+      const response = await putNameRequest(nrNumber.value, data)
+      if (!response.ok) {
+        throw new Error('Failed to update NR')
+      }
       await parseNr(await response.json())
-    } else {
-      emitter.emit('error', {
-        title: `Failed to update NR`,
-        message: `An error occurred while trying to update ${nrNumber.value}`,
-      })
+    } catch {
+        emitter.emit('error', {
+          title: `Failed to update NR`,
+          message: `An error occurred while trying to update ${nrNumber.value}`,
+        })
       await fetchAndLoadNr(nrNumber.value)
     }
   }