Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASPER-176/253: Testing Framework and Components #116

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

JTraill
Copy link

@JTraill JTraill commented Dec 19, 2024

Pull Request for JIRA Ticket: ----176 and 253----

https://jag.gov.bc.ca/jira/browse/JASPER-176
https://jag.gov.bc.ca/jira/browse/JASPER-253

Description

This PR introduces a generic button component that will be used across the system.
I went to unit test it and saw there is no testing framework in the project, so I added the necessary vue testing tools and I added Vitest as it is the best (in my opinion) option for Vue3/Vite environments https://vitest.dev/

In the future we can hook this up to the CI PR build and prevent any PR's that would be breaking unit tests from being merged.

feat: button group component
test: add tests for button grouping component
build: add testing packages
refactor: remove unneeded nav bars

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran start and debug locally
  • Ran unit tests
    image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

component: button group component
build: add testing packages
@JTraill JTraill self-assigned this Dec 19, 2024
@JTraill JTraill changed the title JASPER-176: Testing Framework and Components JASPER-176/256: Testing Framework and Components Dec 19, 2024
@JTraill JTraill marked this pull request as ready for review December 19, 2024 21:54
@JTraill JTraill changed the title JASPER-176/256: Testing Framework and Components JASPER-176/253: Testing Framework and Components Dec 19, 2024
@WadeBarnes WadeBarnes merged commit 22b3a7f into master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants