Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASPER-176: Further Component Standardization/SVGs #115

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

JTraill
Copy link

@JTraill JTraill commented Dec 18, 2024

Pull Request for JIRA Ticket: ----176----

https://jag.gov.bc.ca/jira/browse/JASPER-176

Description

Moved mdi usage from PNG => SVG. SVG's are much smaller, space conscious and performant. This is also recommended in the Vuetify documentation: https://vuetifyjs.com/en/features/icon-fonts/#mdi-js-svg
Standardized more of our component defaulting
Changed the incorrect font to the correct one

refactor: mdi uses svgs instead of png
build: move mdi to dev dep
build: add mdi js as dev dep
style: component style standardization
style: font style

How Has This Been Tested?

  • Local tests, ran debug and start

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Example of some of the new component defaults
image

style: component style standardization
style: font style
@JTraill JTraill changed the title JASPER-175: Further Component Standardization/SVGs JASPER-176: Further Component Standardization/SVGs Dec 18, 2024
@JTraill JTraill self-assigned this Dec 18, 2024
@JTraill JTraill marked this pull request as ready for review December 18, 2024 00:15
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One comment regarding fonts. As we move forward we should consider integrating the
BC Sans Typeface
fonts. They have been specifically designed to support special characters and syllabics found in Indigenous Languages in BC.

@JTraill
Copy link
Author

JTraill commented Dec 18, 2024

LGTM

One comment regarding fonts. As we move forward we should consider integrating the BC Sans Typeface fonts. They have been specifically designed to support special characters and syllabics found in Indigenous Languages in BC.

I've made note of that. Will include it in a future PR!

@JTraill JTraill merged commit 12d9f41 into master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants