-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JASPER-223: Deploy JASPER application to Test #102
Conversation
…anning and deploying infra resources - Updated initial stack to be part of the main stack file to preserve single state file - Added db subnet group for rds - Updated openshift jobs to allow to target different environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I'll defer to @amlanc1 for final review and approval.
One question though. Would using Terraform workspaces simplify the management of the various environments? e.g. Reduce the number of files and any duplication.
- Added logic to set default env variable when GHA is triggered by pull request
Thank you for the advanced review. I was meaning to mark this as ready for PR review once I resolved the build errors found by the pre-checks and cleanup. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved... looks good to be deployed. For now the environment folders are ok. We can look at Terragrunt for better environment management in Terraform. The Terraform workspace wont work for our use case as Workspace is mostly applicable when working with single state file. But here we have separate state files in each environment.
Pull Request for JIRA Ticket: JASPER-223
Issue ticket number and link
https://jag.gov.bc.ca/jira/browse/JASPER-223
Description
Github Actions
build-infra
pipeline to simplify logic for building, scanning and executingterraform plan
command.publish-infra
pipeline to combine jobs to a single job that deploys theinitial
stack, deploys the dummy-image (for ECR and Lambda) and finally, themain
stack to provision Jasper's cloud infrastructureOpenshift
Terraform
initial
stack andmain
stack to a one file so that it would be easy to use one Terraform state file.db_subnet_group
for the Postgres db which was originally created via Consoleinitial
stack to modules.Type of change
How Has This Been Tested?
dev
andtest
Checklist: