Skip to content

Commit

Permalink
Merge pull request #92 from bcgov/feature/vue3
Browse files Browse the repository at this point in the history
JASPER-157: Vue 3 Migration
  • Loading branch information
WadeBarnes authored Dec 9, 2024
2 parents 59a3090 + eca4cb9 commit 656d7b5
Show file tree
Hide file tree
Showing 89 changed files with 16,799 additions and 24,839 deletions.
28 changes: 28 additions & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Ignore dependencies
**/node_modules
bin
obj
dist
build

# Ignore logs and temporary files
*.log
*.tmp
*.pid
*.bak

# Ignore IDE/editor files
.vscode
.idea
*.suo
*.user
*.sln.docstates

# Ignore OS files
.DS_Store
Thumbs.db
__MACOSX

# Ignore Git files
.git
.gitignore
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test-web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [12.x]
node-version: [18.x]
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/publish-web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

strategy:
matrix:
node-major-version: [12]
node-major-version: [18]
node-minor-version: [x]

steps:
Expand Down Expand Up @@ -79,7 +79,6 @@ jobs:
NGINX_RUNTIME_SRC=../../docker/nginx-runtime
VUE_ON_NGINX_SRC=../../docker/vue-on-nginx
WEB_SRC=../../web
NPM_INSTALL_ARGS=--unsafe-perm
deploy2dev:
name: Deploy to DEV
Expand Down
8 changes: 8 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"singleQuote": true,
"semi": true,
"vueIndentScriptAndStyle": true,
"trailingComma": "es5",
"printWidth": 80,
"tabWidth": 2
}
5 changes: 3 additions & 2 deletions docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ services:
- DEV_MODE=false
- NODE_ENV=development
- NPM_CONFIG_LOGLEVEL=notice
- NPM_RUN=serve
- VITE_PORT=1339
- CHOKIDAR_USEPOLLING=true
ports:
- 8080:1339
- "8080:1339"
volumes:
- "${LOCAL_WORKSPACE_FOLDER-..}/web/src:/opt/app-root/src/src"
- "${LOCAL_WORKSPACE_FOLDER-..}/web/package.json:/opt/app-root/src/package.json"
Expand Down
18 changes: 8 additions & 10 deletions docker/manage
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,10 @@ build-web() {
docker build \
-t "${COMPOSE_PROJECT_NAME}-web" \
--build-arg IMAGE_PREFIX=${COMPOSE_PROJECT_NAME}- \
--build-arg NODE_VERSION=12 \
--build-arg NODE_VERSION=18 \
--build-arg NGINX_RUNTIME_SRC='../docker/nginx-runtime' \
--build-arg VUE_ON_NGINX_SRC='../docker/vue-on-nginx' \
--build-arg WEB_SRC='./web' \
--build-arg NPM_INSTALL_ARGS='--unsafe-perm' \
-f './web/Dockerfile.release' '..'
echo -e "===================================================================================================="
}
Expand All @@ -109,15 +108,14 @@ build-web-dev() {
# web-dev
#
echo -e "\n\n===================================================================================================="
echo -e "Building the ${COMPOSE_PROJECT_NAME}-web-dev image using s2i ..."
echo -e "Building the ${COMPOSE_PROJECT_NAME}-web-dev image using Docker ..."
echo -e "----------------------------------------------------------------------------------------------------"
${S2I_EXE} build \
--copy \
-e "DEV_MODE=true" \
-e WEB_BASE_HREF=${WEB_BASE_HREF} \
'../web' \
'centos/nodejs-12-centos7' \
"${COMPOSE_PROJECT_NAME}-web-dev"
docker build \
-t "${COMPOSE_PROJECT_NAME}-web-dev" \
--build-arg NODE_VERSION=18 \
--build-arg VITE_PORT=1339 \
--build-arg WEB_SRC='./web' \
-f './web/Dockerfile.local' '..'
echo -e "===================================================================================================="
}

Expand Down
5 changes: 3 additions & 2 deletions docker/vue-on-nginx/s2i/bin/fix-base-url
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
# Perhaps webpack 5 will have some sort of fix for this.
echo "---> Replacing public path /S2I_INJECT_PUBLIC_PATH/ -> $WEB_BASE_HREF in Vue artifacts..."
FILES="/tmp/app/dist/index.html
/tmp/app/dist/js/*.*"
/tmp/app/dist/assets/*.*"
for f in $FILES
do
tmp=$(sed "s|/S2I_INJECT_PUBLIC_PATH/|$WEB_BASE_HREF|g" "$f");
#tmp=$(sed "s|/S2I_INJECT_PUBLIC_PATH/|$WEB_BASE_HREF|g" "$f");
tmp=$(tr -d '\0' < "$f" | sed "s|/S2I_INJECT_PUBLIC_PATH/|$WEB_BASE_HREF|g")
printf "%s" "$tmp" > "$f";
done

Expand Down
12 changes: 0 additions & 12 deletions docker/web/Dockerfile

This file was deleted.

24 changes: 24 additions & 0 deletions docker/web/Dockerfile.local
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
ARG NODE_VERSION=18
ARG VITE_PORT=1339
ARG WEB_SRC=./web

FROM registry.access.redhat.com/ubi9/nodejs-${NODE_VERSION}
ARG WEB_SRC
ARG VITE_PORT

WORKDIR /opt/app-root/src

COPY ${WEB_SRC}/package*.json ./

USER root

RUN npm install

COPY ${WEB_SRC} .

ENV VITE_PORT=${VITE_PORT}

EXPOSE ${VITE_PORT}

# Run the development server
CMD npm run dev
2 changes: 1 addition & 1 deletion docker/web/Dockerfile.release
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ USER 104
###################################################################################
# 2. Build web-artifacts
###################################################################################
FROM quay.io/centos7/nodejs-${NODE_VERSION}-centos7:${NODE_VERSION} AS artifacts
FROM registry.access.redhat.com/ubi9/nodejs-${NODE_VERSION} AS artifacts
ARG NODE_VERSION
ARG WEB_SRC
ARG NPM_INSTALL_ARGS
Expand Down
18 changes: 0 additions & 18 deletions package-lock.json

This file was deleted.

6 changes: 0 additions & 6 deletions web/babel.config.js

This file was deleted.

7 changes: 4 additions & 3 deletions web/public/index.html → web/index.html
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head lang="en">
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<link rel="icon" href="<%= BASE_URL %>favicon.ico">
<title>Supreme Court Viewer</title>
<link rel="icon" href="./favicon.ico">
<title>JASPER</title>
</head>
<body>
<noscript>
<strong>We're sorry but SCV.App doesn't work properly without JavaScript enabled. Please enable it to continue.</strong>
</noscript>
<div id="app"></div>
<script type="module" src="./src/main.ts"></script>
<!-- built files will be auto injected -->
</body>
</html>
Loading

0 comments on commit 656d7b5

Please sign in to comment.