Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTSD-319 Fix Drive Space Loading #129

Merged
merged 1 commit into from
Mar 28, 2024
Merged

HOSTSD-319 Fix Drive Space Loading #129

merged 1 commit into from
Mar 28, 2024

Conversation

Fosol
Copy link
Contributor

@Fosol Fosol commented Mar 28, 2024

Fixed state issue when loading file system items.

image

@Fosol Fosol added the bug Something isn't working label Mar 28, 2024
@Fosol Fosol self-assigned this Mar 28, 2024
const fileSystemItems = useFilteredStore((state) => state.fileSystemItems);
const setFileSystemItems = useFilteredStore((state) => state.setFileSystemItems);

const [isLoading, setIsLoading] = React.useState(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look hook state was causing the issue. Every different hook would have it's own state. As such the hook for the filter was not the same state variable as the one used on the dashboard. Loading state has been moved to the zustand store.

@Fosol Fosol merged commit 70e69d2 into bcgov:main Mar 28, 2024
1 check passed
@Fosol Fosol deleted the 319 branch March 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant