HOSTSD-293 - fix for storage trends chart aspect ratio bug #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
reviewed
Mar 27, 2024
| @@ -173,6 +173,26 @@ export const Dashboard = () => { | |||
| [download], | |||
| ); | |||
|
|
|||
| const renderStorageTrendsChart = (isLarge: boolean) => { | |||
There was a problem hiding this comment.
Should this use a React.useCallback()?
There was a problem hiding this comment.
for the callback, should I use all the variables this component depends on as dependencies?
ex: [ dashboardServerItem, dashboardServerItems, dashboardTenant, dashboardOrganization, dashboardOperatingSystemItem, handleExport, ]
There was a problem hiding this comment.
If you test using them all you'll find out if it gets in an infinite loop. But generally you want all of them.
Fosol
approved these changes
Mar 27, 2024
Fosol
reviewed
Mar 27, 2024
| @@ -173,6 +173,34 @@ export const Dashboard = () => { | |||
| [download], | |||
| ); | |||
|
|
|||
| const renderStorageTrendsChart = React.useCallback( | |||
| (isLarge: Boolean) => ( | |||
There was a problem hiding this comment.
You'll need to change from Boolean to boolean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storage Trends chart aspect ratio was off when navigating back to the All Organizations view - the chart was too short because it was keeping the longer aspect ratio from the larger size of the chart on other views.
To fix this, it seems the chart needs to be rendered separately for each size depending on which view the user is looking at.