HOSTSD-240 Keep removed servers #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DB migration 1.0.3
Fosol
added
enhancement
Fosol
commented
Mar 27, 2024
| @@ -129,7 +129,7 @@ public IActionResult GetForId(string id) | |||
| [Produces(MediaTypeNames.Application.Json)] | |||
| [ProducesResponseType(typeof(IEnumerable<FileSystemHistoryItemModel>), (int)HttpStatusCode.OK)] | |||
| [SwaggerOperation(Tags = new[] { "File System Item" })] | |||
| [ResponseCache(VaryByQueryKeys = new[] { "*" }, Location = ResponseCacheLocation.Client, Duration = 1200)] | |||
| // [ResponseCache(VaryByQueryKeys = new[] { "*" }, Location = ResponseCacheLocation.Client, Duration = 1200)] | |||
There was a problem hiding this comment.
Disable caching for now.
| , "ServerItemServiceNowKey" | ||
| , "InstallStatus" | ||
| FROM ( | ||
| SELECT fshi.* |
There was a problem hiding this comment.
Get the most recent values. In the current month only return installed items.
| , "ServerItemServiceNowKey" | ||
| , "InstallStatus" | ||
| FROM ( | ||
| SELECT fshi.* |
There was a problem hiding this comment.
Get the most recent values. In the current month only return installed items.
| , "Version" | ||
| , "InstallStatus" | ||
| FROM ( | ||
| SELECT * |
There was a problem hiding this comment.
Get the most recent values. In the current month only return installed items.
| , "Version" | ||
| , "InstallStatus" | ||
| FROM ( | ||
| SELECT shi.* |
There was a problem hiding this comment.
Get the most recent values. In the current month only return installed items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Data Service will no longer delete removed servers and file systems items. Instead it will update their install status to
0. The service has also been updated to improve the consistency of data between history and current storage values. There is still a difference regrettably, but I haven't figured out what causes the difference.When requesting historical data it will now include uninstalled items for the prior months, but only installed items for the current month. If the user selects invalid date range it will result in no data returned.
I've also disabled caching to see if it improves various data issues without too much of a hit to performance.
Added DB migration 1.0.3