HOSTSD-276 Storage Trend Size Type #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Mar 21, 2024
| @@ -31,8 +32,13 @@ interface LineChartProps { | |||
| loading?: boolean; | |||
| /** Date range selected for the filter. */ | |||
| dateRange?: string[]; | |||
| /** An array of server items */ | |||
| serverItems?: IServerItemListModel[]; | |||
There was a problem hiding this comment.
Need to pass the selected server items down so that it can be determine which storage size they are using.
| @@ -56,6 +63,8 @@ export const StorageTrendsChart: React.FC<LineChartProps> = ({ | |||
| const { isReady: serverHistoryItemsIsReady, findServerHistoryItems } = useServerHistoryItems(); | |||
| const { tenantId, organizationId, operatingSystemItemId, serverItemKey } = useDashboard(); | |||
|
|
|||
| const [forceFetch, setForceFetch] = React.useState(0); | |||
There was a problem hiding this comment.
Clicking the Update button doesn't do anything if the date doesn't change. This allows it to force an update.
| const groups = generateStorageHistoryForDateRange(minColumns, dateRange); | ||
|
|
||
| // Determine the output size type to use based on the current total storage of the selected servers. | ||
| const storageSizeType = convertStorageSize( |
| * @param options Configuration options. | ||
| * @returns A string representing the storage size. | ||
| */ | ||
| export const convertToStorageSize = <T extends string | number>( |
There was a problem hiding this comment.
Separated the function into two so that I have access to the logic without the string output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storage Trend chart will now use the same storage size type as the Total Storage Allocation chart.