Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTSD-315 - adding toast messages for excel export functions #120

Merged
merged 1 commit into from
Mar 19, 2024
Merged

HOSTSD-315 - adding toast messages for excel export functions #120

merged 1 commit into from
Mar 19, 2024

Conversation

wkaspryk
Copy link
Collaborator

Adding React Toast messages for excel export loading state - toast.loading: "Generating Excel document...", and toast.success: "Excel document has been downloaded successfully."

@Fosol Fosol added the enhancement New feature or request label Mar 19, 2024
Fosol
Fosol approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a shared function to keep this cleaner. I can do that later.

@wkaspryk wkaspryk marked this pull request as ready for review March 19, 2024 18:03
@Fosol Fosol added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit b659f93 Mar 19, 2024
2 checks passed
@Fosol Fosol deleted the 315 branch March 19, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@wkaspryk wkaspryk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkaspryk @Fosol