Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTSD-271 - Updating Breadcrumbs and adding totals to server charts #100

Merged
merged 2 commits into from
Feb 29, 2024
Merged

HOSTSD-271 - Updating Breadcrumbs and adding totals to server charts #100

merged 2 commits into from
Feb 29, 2024

Conversation

wkaspryk
Copy link
Collaborator

  • Updating breadcrumbs and header messaging so they only update after the dashboard has been updated (after 'update' button in Filter is clicked). Using useDashboardStore instead of useFilteredStore.
  • Server charts: Adding OS name to chart when looking at single OS page. Adding totals for allocated and unused space at the top of the charts.
  • Including a few small style fixes

@wkaspryk wkaspryk requested a review from Fosol February 29, 2024 17:28
@Fosol Fosol added the enhancement New feature or request label Feb 29, 2024
Fosol
Fosol approved these changes Feb 29, 2024
View reviewed changes
src/dashboard/src/components/charts/allocationTable/AllocationTable.tsx Outdated
@@ -13,7 +13,7 @@ import { ITableRowData } from './ITableRowData';
import { TableRow } from './TableRow';
import { useAllocationByOS } from './hooks';
import { getColumns, getLabel } from './utils';

import { convertToStorageSize } from './../../../utils/convertToStorageSize';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can use @/utils

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@Fosol Fosol added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit c0d5b99 Feb 29, 2024
1 check passed
@Fosol Fosol deleted the 271 branch February 29, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@wkaspryk wkaspryk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkaspryk @Fosol