Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity UIs: update SbcFooter #21761

Closed
3 tasks done
severinbeauvais opened this issue Jun 12, 2024 · 4 comments
Closed
3 tasks done

Entity UIs: update SbcFooter #21761

severinbeauvais opened this issue Jun 12, 2024 · 4 comments
Assignees
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jun 12, 2024

This ticket was spawned from #21054.

The Entity UIs need to import the latest SbcFooter component (from sbc-common-components v3.0.13):

The code differences between sbc-common-component v3.0.8 and v.3.0.13 should be identified so we can verify/test that there are no breaking changes in the Entity UIs.

cc: @OlgaPotiagalova @davemck513 @ozamani9gh

@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Jun 12, 2024
@severinbeauvais severinbeauvais added the Entities - David A label to filter on the tickets for the Entities based team that David is PO for. label Jun 12, 2024
@severinbeauvais
Copy link
Collaborator Author

Dave, Olga, what's the priority of this work and which team can do it?

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jun 13, 2024

I have created this draft PR to show the changes from v3.0.8 to v3.0.13:
bcgov/sbc-common-components#368

My analysis is that there are no breaking changes -- mainly an update to the footer (which we want) and an update to the header (which is good to have). So this is a small ticket that only requires importing the latest library and testing.

@severinbeauvais
Copy link
Collaborator Author

Test Notes

The SbcFooter now has a link to the Release Notes.

The SbcHeader logo (top left) now supports an "environment" alert, but this requires a new prop to be passed in, and we don't have a requirement to do that. The way it would work is that it would display an alert (eg, "DEVELOPMENT Environment" in green, "TEST Environment" in red, or "SANDBOX Environment" in orange) to let the user know what environment they are currently using.

@NaveenHebbale
Copy link

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.
Projects
None yet
Development

No branches or pull requests

2 participants