Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 filter out Report Facilities crumb from breadcrumb component #2727

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

shon-button
Copy link
Contributor

@shon-button shon-button commented Jan 23, 2025

Ticket 352

🚀 Impact:

  • Filter out App specific crumb via path segment transformation based on App pathnames and crumb name-"Reports\...\Facilities\..."

🔬 Local Testing:

  1. From terminal command, start the api server:
cd bc_obps
make reset_db
make run
  1. From terminal command, start the app development server:
cd bciers && yarn dev-all

Test for "Facilities" crumb in Nx Apps

  1. Navigate to http://localhost:3000
  2. Click button "Log in with Business BCeID"
  3. Navigate to ADMIN App Facilities route: http://localhost:3000/administration/operations/002d5a9e-32a6-4191-938c-2c02bfec592d/facilities?operations_title=Banana+LFO+-+Registered
    Expected Results
  • Facilities crumb displays in breadcrumbs
    image
  1. Navigate to REPORTING App Facilities route: http://localhost:3000/reporting/reports/1/facilities/f486f2fb-62ed-438d-bb3e-0819b51e3aff/activities
    Expected Results
  • Facilities crumb DOES NOT display in breadcrumbs
    image

@shon-button shon-button force-pushed the chore/352-report-facilities-breadcrumbs branch from 35e766e to 15a2376 Compare January 23, 2025 16:47
Copy link
Contributor

@gdalcengio gdalcengio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner and more future proof! Thank you, approved!

@shon-button shon-button merged commit 2b27614 into develop Jan 23, 2025
42 checks passed
@shon-button shon-button deleted the chore/352-report-facilities-breadcrumbs branch January 23, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants