-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed the intermittent page 404 error #50
Conversation
/gcbrun |
@@ -88,7 +88,7 @@ export default defineNuxtConfig({ | |||
file: 'fr-CA.ts' | |||
} | |||
], | |||
strategy: 'prefix', | |||
strategy: 'prefix_except_default', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the main culprit. Basically, what this was doing, is add that prefix to everything. This messed up the routing and needed middleware and other stuff. Changing this now follows proper routing in such that "/account/3040" works for example directly without the need to process it using extra code.
Temporary Url for review: https://business-registry-dev--pr-50-atqlpmd1.web.app https://business-registry-dev--pr-50-atqlpmd1.web.app/account/3040 Sev, can you please give these a try and tell me if you still see this error? @severinbeauvais |
I didn't see the 404 page. I didn't see the 404 page but I do see this: I didn't see the 404 page but I do see this: |
I noticed this: no re-routes and therefore much faster to get to the page. Well done! |
These dialogs are OK. They are old links that I pulled up from old PRs. The idea is just to test the routing. If we're getting to the BRD with no errors, it's good. |
bcgov/entity#25225
Fixed the page 404 error that is shown for about a second before showing the page.
Also, this error should be fixed for the magic links.
ALSO, as a part of this fix, the multiple/extra redirections of all routes are no longer present since I removed the middleware 😁 Things should be faster now.
Basically this makes routing much much better across the board across all links (magic link, incorporate now, and the BRD of accounts).