Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed a ton of UX table issues + misc. fixes #31

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

JazzarKarim
Copy link
Collaborator

Issue #: /bcgov/entity#23341

Changes:

If you have any questions about any fix, let me know. I can clarify.

@JazzarKarim JazzarKarim self-assigned this Nov 22, 2024
@JazzarKarim JazzarKarim marked this pull request as ready for review November 22, 2024 23:51
@bcgov bcgov deleted a comment from bcregistry-sre Nov 23, 2024
@bcgov bcgov deleted a comment from bcregistry-sre Nov 23, 2024
@JazzarKarim
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-registry-dev--pr-31-0ls5hoj4.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JazzarKarim JazzarKarim merged commit 7da1a93 into bcgov:main Nov 27, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants