Skip to content

Commit

Permalink
Merge pull request #41 from JazzarKarim/24920-ff-target-redirection
Browse files Browse the repository at this point in the history
feat: changed to use new BRD feature flags
  • Loading branch information
severinbeauvais authored Dec 24, 2024
2 parents 6b7bbab + a83ceeb commit 5a85717
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions business-registry-dashboard/app/enums/ld-flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ export enum LDFlags {
BannerText = 'banner-text',
BusSearchLink = 'bus-search-staff-link',
EnableBcCccUlc = 'enable-bc-ccc-ulc',
EnableBcCccUlcBrd = 'enable-bc-ccc-ulc-brd',
EnableBusinessNrSearch = 'enable-business-nr-search',
EnableDetailsFilter = 'enable-transactions-detail-filter',
EnableEFTPaymentMethod = 'enable-eft-payment-method',
IaSupportedEntities = 'ia-supported-entities',
IaSupportedEntitiesBrd = 'ia-supported-entities-brd',
ProductBCAStatus = 'product-BCA-status',
ProductBusSearchPremTooltip = 'product-BUSINESS_SEARCH-prem-tooltip',
ProductBusSearchStatus = 'product-BUSINESS_SEARCH-status',
Expand Down
2 changes: 1 addition & 1 deletion business-registry-dashboard/app/utils/business.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function isSocieties (item: Business): boolean {

export function isModernizedEntity (item: Business): boolean {
const ldStore = useConnectLaunchdarklyStore()
const supportedEntityFlags = ldStore.getStoredFlag(LDFlags.IaSupportedEntities)
const supportedEntityFlags = ldStore.getStoredFlag(LDFlags.IaSupportedEntitiesBrd)
const entityType = getEntityType(item)
if (typeof supportedEntityFlags === 'string') {
return supportedEntityFlags.split(' ').includes(entityType)
Expand Down
2 changes: 1 addition & 1 deletion business-registry-dashboard/app/utils/name-request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function mapRequestTypeCdToNrType (requestTypeCd: NrRequestTypeCodes): st
/* Internal function to build the namerequest object. */
export function buildNameRequestObject (nr: NameRequestResponse) {
const ldStore = useConnectLaunchdarklyStore()
const enableBcCccUlc = ldStore.getStoredFlag(LDFlags.EnableBcCccUlc) || false
const enableBcCccUlc = ldStore.getStoredFlag(LDFlags.EnableBcCccUlcBrd) || false

/** Returns True if NR has applicants for registration. */
const isApplicantsExist = (nr: NameRequestResponse): boolean => {
Expand Down
2 changes: 1 addition & 1 deletion business-registry-dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "business-registry-dashboard",
"private": true,
"type": "module",
"version": "0.0.11",
"version": "0.0.12",
"scripts": {
"build-check": "nuxt build",
"build": "nuxt generate",
Expand Down

0 comments on commit 5a85717

Please sign in to comment.