Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19392 cco field details removed #158

Merged
merged 1 commit into from
Mar 23, 2024
Merged

19392 cco field details removed #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/registry_schemas/example_data/schema_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,7 +1365,6 @@
}

CONSENT_CONTINUATION_OUT = {
'details': 'A note to explain the consent to continue out',
'foreignJurisdiction': FOREIGN_JURISDICTION,
'courtOrder': COURT_ORDER
}
Expand Down
9 changes: 0 additions & 9 deletions src/registry_schemas/schemas/consent_continuation_out.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@
"foreignJurisdiction"
],
"properties": {
"details": {
"type": [
"string",
"null"
],
"minLength": 1,
"maxLength": 2000,
"description": "A brief note to explain the consent to continue out."
},
"foreignJurisdiction": {
"$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/foreign_jurisdiction"
},
Expand Down
2 changes: 1 addition & 1 deletion src/registry_schemas/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"""


__version__ = '2.18.20' # pylint: disable=invalid-name
__version__ = '2.18.21' # pylint: disable=invalid-name
19 changes: 0 additions & 19 deletions tests/unit/test_consent_continuation_out.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,22 +65,3 @@ def test_consent_continuation_out_invalid_jurisdiction():
print(errors)

assert not is_valid


@pytest.mark.parametrize('details', [
('some details'),
(None)
])
def test_consent_continuation_out_validate_details(details):
"""Assert that the JSONSchema is validating details."""
legal_filing = {'consentContinuationOut': copy.deepcopy(CONSENT_CONTINUATION_OUT)}
legal_filing['consentContinuationOut']['details'] = details

is_valid, errors = validate(legal_filing, 'consent_continuation_out')

if errors:
for err in errors:
print(err.message)
print(errors)

assert is_valid
Loading