18537 Amalgamation application schema #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
argush3
reviewed
Dec 4, 2023
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
argush3
reviewed
Dec 5, 2023
|
do we need to support name translations like IA filing?
|
Yes, good catch! |
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
severinbeauvais
approved these changes
Dec 6, 2023
|
You will need to update
|
Signed-off-by: Hongjing Chen <[email protected]>
severinbeauvais
approved these changes
Dec 6, 2023
argush3
approved these changes
Dec 6, 2023
JazzarKarim
approved these changes
Dec 6, 2023
thorwolpert
reviewed
Dec 7, 2023
| @@ -85,6 +85,168 @@ | |||
| 'deliveryInstructions': 'some delivery instructions' | |||
| } | |||
|
|
|||
| COURT_ORDER = { | |||
There was a problem hiding this comment.
Any reason why this was moved?
| "enum": [ | ||
| "registration", | ||
| "incorporationApplication", | ||
| "amalgamationApplication" |
There was a problem hiding this comment.
Do we not want the business header block for Amalgamations?
thorwolpert
approved these changes
Dec 7, 2023
JazzarKarim
pushed a commit
to JazzarKarim/business-schemas
that referenced
this pull request
Jan 31, 2024
* 18537 Signed-off-by: Hongjing Chen <[email protected]> * 18537-2 Signed-off-by: Hongjing Chen <[email protected]> * fix-1 Signed-off-by: Hongjing Chen <[email protected]> * fix-2 Signed-off-by: Hongjing Chen <[email protected]> * fix-3 Signed-off-by: Hongjing Chen <[email protected]> * revert - remove foreign prefix Signed-off-by: Hongjing Chen <[email protected]> * fix linting Signed-off-by: Hongjing Chen <[email protected]> * rename amalgamation to amalgamationApplication Signed-off-by: Hongjing Chen <[email protected]> --------- Signed-off-by: Hongjing Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#18537
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).