17796 Allow firm registration for single name user/account #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
chenhongjing
changed the title
|
Can you update the version https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/version.py#L26 |
Signed-off-by: Hongjing Chen <[email protected]>
argush3
reviewed
Oct 10, 2023
Signed-off-by: Hongjing Chen <[email protected]>
thorwolpert
reviewed
Oct 11, 2023
| "properties": { | ||
| "firstName": { "minLength": 1 } | ||
| }, | ||
| "required": ["firstName"] |
There was a problem hiding this comment.
We can probably change the schema to allow a null firstName in all circumstances.
| @@ -958,8 +958,8 @@ | |||
| { | |||
| 'officer': { | |||
| 'id': 2, | |||
| 'firstName': '', | |||
| 'lastName': '', | |||
| 'firstName': 'Peter', | |||
There was a problem hiding this comment.
You shouldn't be able to have name fields and organizationName
Signed-off-by: Hongjing Chen <[email protected]>
thorwolpert
approved these changes
Oct 11, 2023
Signed-off-by: Hongjing Chen <[email protected]>
argush3
approved these changes
Oct 11, 2023
JazzarKarim
pushed a commit
to JazzarKarim/business-schemas
that referenced
this pull request
Jan 31, 2024
* 17796 Signed-off-by: Hongjing Chen <[email protected]> * fix some tests Signed-off-by: Hongjing Chen <[email protected]> * fix-2 Signed-off-by: Hongjing Chen <[email protected]> * update version = 2.18.12 Signed-off-by: Hongjing Chen <[email protected]> * update required fields Signed-off-by: Hongjing Chen <[email protected]> * fix-3 Signed-off-by: Hongjing Chen <[email protected]> * update version=2.18.13 Signed-off-by: Hongjing Chen <[email protected]> --------- Signed-off-by: Hongjing Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#17796
Description of changes:
personpersonBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).