New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit UI: add FF to conditionally allow "empty corrections" #608

Merged

severinbeauvais merged 4 commits into bcgov:main from Rajandeep98:25227_Empty_Correction_FF

Jan 13, 2025

Collaborator

Rajandeep98 commented Jan 10, 2025 •

edited by severinbeauvais

Loading

Issue #: /bcgov/entity#25227

Description of changes:
FF to conditionally allow empty corrections


          FF empty corrections

Rajandeep98 requested a review from severinbeauvais

January 10, 2025 18:11

severinbeauvais reviewed

View reviewed changes

src/components/common/Actions.vue Outdated Show resolved Hide resolved

severinbeauvais reviewed

View reviewed changes

src/components/common/Actions.vue Outdated Show resolved Hide resolved

Collaborator

severinbeauvais commented Jan 10, 2025

/gcbrun

Collaborator

bcregistry-sre commented Jan 10, 2025 •

edited by severinbeauvais

Loading

Temporary Url for review: https://business-edit-dev--pr-608-um052ytv.web.app

SB says, try this: https://business-edit-dev--pr-608-um052ytv.web.app/BC0886359/correction/?correction-id=156352


          lint fix + fetch ld flag to allow empty correction

ad8d278

Collaborator Author

Rajandeep98 commented Jan 10, 2025

/gcbrun

severinbeauvais reviewed

View reviewed changes

src/store/store.ts Show resolved Hide resolved

Collaborator

bcregistry-sre commented Jan 10, 2025

Temporary Url for review: https://business-edit-dev--pr-608-um052ytv.web.app

severinbeauvais reviewed

View reviewed changes

Collaborator

severinbeauvais left a comment

In your original PR, you had deleted some unit tests. Can you restore them now?

Ref: https://github.com/bcgov/business-edit-ui/pull/605/files


          comments removed

f63e8d2

severinbeauvais reviewed

View reviewed changes

src/store/store.ts Show resolved Hide resolved


          unit tests restored

08af2e8

severinbeauvais reviewed

View reviewed changes

Collaborator

severinbeauvais left a comment

The correction filing is behaving perfectly 👍

Let me turn On the feature flag and test again.

Collaborator

severinbeauvais commented Jan 10, 2025 •

edited

Loading

With FF enabled (so detail-only should be allowed), if I edit the Articles -- which makes the component invalid -- the File and Pay button is still enabled.

Check isCorrectionEditing -- it might be missing the check for the Articles component.

severinbeauvais approved these changes

View reviewed changes

Collaborator

severinbeauvais left a comment

LGTM

Collaborator

severinbeauvais commented Jan 13, 2025

We will create another ticket for the "Articles" issue.

This PR is ready to go.

severinbeauvais merged commit 208a566 into bcgov:main

8 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet