16052 Migration to Vue3 changes - DO NOT MERGE #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enabled eslint rule overrides
- app version = 4.3.3
- auto-fixed "id must come first"
- auto-fixed "one property per line"
- auto-fixed "property needs double quotes"
- auto-fixed "v-for must come first"
- auto-fixed "one space after {{ and before }}"
- auto-fixed "use self-closing HTML elements"
- auto-fixed "#activator"
- auto-fixed "key must come before other properties"
- etc
- uninstalled bcrs packages (needs to be re-installed later) - updated dependencies for Vue3 - uninstalled vuex and vuex-class - updated tsconfig.json - updated vue.config.js
- added some eslint rule exceptions - changed 'vue-property-decorator' to 'vue-facing-decorator' - used Vue from vue-facing-decorator - changed 'pinia-class' to '@/utils/' - copied shared components locally (for compatibility) and removed their package.json files + updated shared imports - updated mixin references - changed duplicate boolean in declarations - changed Vue.nextTick() to this.$nextTick() (except unit tests)
- added some dependencies (needed by sbc-common-components) and updated others - uninstalled sbc-common-components - copied common components locally (for compatibility) and removed their local config files + updated common imports - moved PiniaClass.ts from utils/ to store/
- disabled rule no-unused-vars and added rule @typescript-eslint/no-unused-vars instead - added env option - added parser option - re-installed shared breadcrumb - re-installed shared corp-type-module - re-installed shared interfaces - re-installed sbc-common-components - upgraded vue-router from v3 to v4 - upgraded eslint-config-standard from v4 to v8 - upgraded eslint-config-typescript from v9 to v11 - upgraded eslint-plugin-vue from v8 to v9 - added shim-vuetify.d.ts - updated shim-vue.d.ts - auto-fixed lint issues (ie, code style) - copied in sbc-common-components from search-ui
severinbeauvais
commented
Apr 27, 2023
| tile dense | ||
| v-if="bannerText" | ||
| rounded="0" | ||
| density="compact" |
There was a problem hiding this comment.
Need to test "tile" vs "rounded", and "dense" vs "density".
severinbeauvais
changed the title
- installed shared enums - updated some imports to local sbc-common-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#16052
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).