21790 - Filing history template and item headers (#18)

* 21790 - adding filng templates bases.

* 21790 - some style updates.

* 21790 - eslint fixes.

* 21790 - test fixes.

* 21790 - pr changes.

* 21790 - updating tests and some after PR changes stuff.

cypress/e2e/components/filings/section.cy.ts

@@ -0,0 +1,13 @@
+import { allFilings } from '../../../fixtures/filings/allFilings'
+
+context('Filings history section', () => {
+  it('Verifies filing history is displayed, and it shows data', () => {
+    cy.visitBusinessDashFor('businessInfo/ben/active.json', undefined, false, undefined, allFilings)
+
+    cy.get('[data-cy="filingHistoryItem-header"]').should('have.length', allFilings.length)
+
+    cy.get('[data-cy="filingHistoryItem-header"]').each((header, index) => {
+      cy.wrap(header).should('contain.text', allFilings[index].displayName)
+    })
+  })
+})

cypress/e2e/initial-page-load.cy.ts

@@ -5,6 +5,8 @@ context('Business Dashboard -> Basic page rendering tests', () => {
 
   it('Loads the page with expected text', () => {
     cy.get('[data-cy="business-dashboard"]').should('exist')
-    cy.get('[data-cy="business-dashboard"]').should('contain.text', 'TBD')
+
+    cy.get('[data-cy="business-dashboard"]').should('contain.text', 'To Do (0)')
+    cy.get('[data-cy="business-dashboard"]').should('contain.text', 'Recent Filing History (0)')
   })
 })

cypress/fixtures/filings/addressChange/completed.ts

@@ -0,0 +1,26 @@
+export const addressChange = {
+  availableOnPaperOnly: false,
+  businessIdentifier: 'CP1002605',
+  commentsCount: 0,
+  commentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/149681/comments',
+  data: {
+    applicationDate: '2024-07-02T07:00:00+00:00',
+    legalFilings: [
+      'changeOfAddress'
+    ]
+  },
+  displayLedger: true,
+  displayName: 'Address Change',
+  documentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/149681/documents',
+  effectiveDate: 'Tue, 02 Jul 2024 16:30:56 GMT',
+  filingId: 149681,
+  filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/149681',
+  isFutureEffective: false,
+  name: 'changeOfAddress',
+  paymentStatusCode: 'COMPLETED',
+  status: 'COMPLETED',
+  submittedDate: 'Tue, 02 Jul 2024 16:30:56 GMT',
+  submitter: 'Registry Staff'
+}

cypress/fixtures/filings/allFilings.ts

@@ -0,0 +1,19 @@
+import { ApiResponseFilingI } from '../../../src/interfaces/filing-i'
+import { addressChange } from './addressChange/completed'
+import { annualReport } from './annualReport/completed'
+import { directorChange } from './directorChange/directorChange'
+import { administrativeDissolution } from './dissolution/administrativeDissolution'
+import { bcGeneralPartnershipRegistration } from './bcGeneralPartnershipRegistration/bcGeneralPartnershipRegistration'
+import { changeOfRegistrationApplication } from './changeOfRegistrationApplication/changeOfRegistrationApplication'
+import { incorporationApplication } from './incoporationApplication/incorporationApplication'
+
+export const allFilings: ApiResponseFilingI[] =
+  [
+    addressChange,
+    annualReport,
+    directorChange,
+    administrativeDissolution,
+    bcGeneralPartnershipRegistration,
+    changeOfRegistrationApplication,
+    incorporationApplication
+  ]

cypress/fixtures/filings/annualReport/completed.ts

@@ -0,0 +1,31 @@
+export const annualReport = {
+  availableOnPaperOnly: false,
+  businessIdentifier: 'BC0814603',
+  commentsCount: 0,
+  commentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144620/comments',
+  data: {
+    annualReport: {
+      annualGeneralMeetingDate: null,
+      annualReportDate: '2011-01-25',
+      annualReportFilingYear: 2011
+    },
+    applicationDate: '2011-01-25',
+    legalFilings: [
+      'annualReport'
+    ]
+  },
+  displayLedger: true,
+  displayName: 'Annual Report (2011)',
+  documentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144620/documents',
+  effectiveDate: 'Mon, 24 Apr 2023 05:40:24 GMT',
+  filingId: 144620,
+  filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144620',
+  isFutureEffective: false,
+  name: 'annualReport',
+  paymentStatusCode: 'COMPLETED',
+  status: 'COMPLETED',
+  submittedDate: 'Mon, 24 Apr 2023 05:40:24 GMT',
+  submitter: 'Registry Staff'
+}

cypress/fixtures/filings/bcGeneralPartnershipRegistration/bcGeneralPartnershipRegistration.ts

@@ -0,0 +1,31 @@
+export const bcGeneralPartnershipRegistration =
+    {
+      availableOnPaperOnly: false,
+      businessIdentifier: 'FM1060265',
+      commentsCount: 0,
+      commentsLink:
+        'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1060265/filings/147287/comments',
+      data: {
+        applicationDate: '2023-11-28T23:55:58.822929+00:00',
+        legalFilings: [
+          'registration'
+        ],
+        registration: {
+          legalName: "BTR'S GENERAL PARTNERSHIP",
+          nrNumber: 'NR 0474544'
+        }
+      },
+      displayLedger: true,
+      displayName: 'BC General Partnership Registration',
+      documentsLink:
+        'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1060265/filings/147287/documents',
+      effectiveDate: 'Tue, 28 Nov 2023 23:56:00 GMT',
+      filingId: 147287,
+      filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1060265/filings/147287',
+      isFutureEffective: false,
+      name: 'registration',
+      paymentStatusCode: 'APPROVED',
+      status: 'COMPLETED',
+      submittedDate: 'Tue, 28 Nov 2023 23:55:58 GMT',
+      submitter: 'BCREG2 Liang FORTY'
+    }

cypress/fixtures/filings/changeOfRegistrationApplication/changeOfRegistrationApplication.ts

@@ -0,0 +1,28 @@
+export const changeOfRegistrationApplication =
+  {
+    availableOnPaperOnly: false,
+    businessIdentifier: 'FM1060265',
+    commentsCount: 0,
+    commentsLink:
+      'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1060265/filings/147691/comments',
+    data: {
+      applicationDate: '2024-01-13T00:17:17.937213+00:00',
+      changeOfRegistration: {},
+      legalFilings: [
+        'changeOfRegistration'
+      ]
+    },
+    displayLedger: true,
+    displayName: 'Change of Registration Application',
+    documentsLink:
+      'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1060265/filings/147691/documents',
+    effectiveDate: 'Sat, 13 Jan 2024 00:17:18 GMT',
+    filingId: 147691,
+    filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/FM1060265/filings/147691',
+    isFutureEffective: false,
+    name: 'changeOfRegistration',
+    paymentStatusCode: 'COMPLETED',
+    status: 'COMPLETED',
+    submittedDate: 'Sat, 13 Jan 2024 00:17:17 GMT',
+    submitter: 'BCREG2 Ayisha FIFTY'
+  }

cypress/fixtures/filings/directorChange/directorChange.ts

@@ -0,0 +1,26 @@
+export const directorChange = {
+  availableOnPaperOnly: false,
+  businessIdentifier: 'CP1002605',
+  commentsCount: 0,
+  commentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/150006/comments',
+  data: {
+    applicationDate: '2024-07-11T07:00:00+00:00',
+    legalFilings: [
+      'changeOfDirectors'
+    ]
+  },
+  displayLedger: true,
+  displayName: 'Director Change',
+  documentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/150006/documents',
+  effectiveDate: 'Thu, 11 Jul 2024 07:00:00 GMT',
+  filingId: 150006,
+  filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/150006',
+  isFutureEffective: false,
+  name: 'changeOfDirectors',
+  paymentStatusCode: 'COMPLETED',
+  status: 'COMPLETED',
+  submittedDate: 'Thu, 11 Jul 2024 18:02:53 GMT',
+  submitter: 'BCREG2 Ayisha FIFTY'
+}

cypress/fixtures/filings/dissolution/administrativeDissolution.ts

@@ -0,0 +1,36 @@
+export const administrativeDissolution = {
+  availableOnPaperOnly: false,
+  businessIdentifier: 'BC0814603',
+  commentsCount: 0,
+  commentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144622/comments',
+  data: {
+    applicationDate: '2023-04-24T05:55:43.070891+00:00',
+    dissolution: {
+      dissolutionDate: '2023-04-24',
+      dissolutionType: 'administrative'
+    },
+    legalFilings: [
+      'dissolution'
+    ],
+    order: {
+      effectOfOrder: 'planOfArrangement',
+      fileNumber: '234234234234',
+      orderDetails: 'asasdasd'
+    }
+  },
+  displayLedger: true,
+  displayName: 'Administrative Dissolution',
+  documentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144622/documents',
+  effectiveDate: 'Mon, 24 Apr 2023 05:55:43 GMT',
+  filingId: 144622,
+  filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144622',
+  filingSubType: 'administrative',
+  isFutureEffective: false,
+  name: 'dissolution',
+  paymentStatusCode: 'COMPLETED',
+  status: 'COMPLETED',
+  submittedDate: 'Mon, 24 Apr 2023 05:55:43 GMT',
+  submitter: 'Registry Staff'
+}

cypress/fixtures/filings/incoporationApplication/incorporationApplication.ts

@@ -0,0 +1,30 @@
+export const incorporationApplication = {
+  availableOnPaperOnly: false,
+  businessIdentifier: 'CP1002605',
+  commentsCount: 0,
+  commentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/147296/comments',
+  data: {
+    applicationDate: '2023-11-29T00:11:46.078781+00:00',
+    incorporationApplication: {
+      legalName: "BTR'S COOP",
+      nrNumber: 'NR 8181266'
+    },
+    legalFilings: [
+      'incorporationApplication'
+    ]
+  },
+  displayLedger: true,
+  displayName: 'Incorporation Application',
+  documentsLink:
+    'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/147296/documents',
+  effectiveDate: 'Wed, 29 Nov 2023 00:11:46 GMT',
+  filingId: 147296,
+  filingLink: 'https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/CP1002605/filings/147296',
+  isFutureEffective: false,
+  name: 'incorporationApplication',
+  paymentStatusCode: 'APPROVED',
+  status: 'COMPLETED',
+  submittedDate: 'Wed, 29 Nov 2023 00:11:46 GMT',
+  submitter: 'BCREG2 Liang FORTY'
+}

cypress/support/commands.ts

@@ -97,6 +97,14 @@ Cypress.Commands.add('interceptTasks', (fixture) => {
   })
 })
 
+Cypress.Commands.add('interceptFilingHistory', (businessIdentifier, filings) => {
+  cy.intercept(
+    'GET',
+    `**/api/v2/businesses/${businessIdentifier}/filings`,
+    { filings }
+  )
+})
+
 Cypress.Commands.add('visitBusinessDash',
   (
     identifier = 'BC0871427',
@@ -140,7 +148,8 @@ Cypress.Commands.add('visitBusinessDashFor',
     path: string,
     identifier = undefined,
     hasAffiliationInvitations = false,
-    taskFixture = 'tasksEmpty.json'
+    taskFixture = 'tasksEmpty.json',
+    filings = []
   ) => {
     sessionStorage.setItem('FAKE_CYPRESS_LOGIN', 'true')
     // settings
@@ -169,6 +178,7 @@ Cypress.Commands.add('visitBusinessDashFor',
       cy.interceptParties(business.legalType, business.state === BusinessStateE.HISTORICAL).as('getParties')
       cy.interceptAffiliationRequests(hasAffiliationInvitations).as('getAffiliationRequests')
       cy.interceptTasks(taskFixture).as('getTasks')
+      cy.interceptFilingHistory(business.identifier, filings).as('getFilingHistory')
 
       // go !
       cy.visit(`/${business.identifier}`)
@@ -180,7 +190,8 @@ Cypress.Commands.add('visitBusinessDashFor',
         '@getAddresses',
         '@getParties',
         '@getAffiliationRequests',
-        '@getTasks'
+        '@getTasks',
+        '@getFilingHistory'
       ])
       cy.injectAxe()
     })

package.json

@@ -32,6 +32,7 @@
     "http-status-codes": "^2.3.0",
     "keycloak-js": "^24.0.4",
     "launchdarkly-vue-client-sdk": "^2.2.0",
+    "lodash.isdate": "^4.0.1",
     "lodash.isequal": "^4.5.0",
     "lodash.omit": "^4.5.0",
     "moment": "^2.30.1",

src/components/bcros/businessDetails/Links.vue

@@ -3,7 +3,7 @@
     <!--    staff comments todo: -->
     <!-- COLIN link button -->
     <span
-      v-if="isDisableNonBenCorps && !!currentBusiness.identifier"
+      v-if="isDisableNonBenCorps() && !!currentBusiness.identifier"
     >
       <BcrosTooltip
         :text="$t('tooltip.filing.button.colinLink')"
@@ -26,7 +26,9 @@
 
     <!-- View and Change Business Information -->
     <span
-      v-if="!isDisableNonBenCorps && currentBusiness.identifier && currentBusiness.state !== BusinessStateE.HISTORICAL"
+      v-if="!isDisableNonBenCorps() &&
+        currentBusiness.identifier &&
+        currentBusiness.state !== BusinessStateE.HISTORICAL"
     >
       <UButton
         id="business-information-button"
@@ -59,7 +61,7 @@
     </span>
 
     <!-- Download Business Summary -->
-    <span v-if="!isDisableNonBenCorps && isAllowedBusinessSummary">
+    <span v-if="!isDisableNonBenCorps() && isAllowedBusinessSummary">
       <BcrosTooltip
         :text="$t('tooltip.filing.button.businessSummary')"
         :popper="{
@@ -89,7 +91,7 @@
     </span>
 
     <div class="mb-2">
-      <BcrosBusinessDetailsLinkActions v-if="!isDisableNonBenCorps && currentBusiness.identifier" />
+      <BcrosBusinessDetailsLinkActions v-if="!isDisableNonBenCorps() && currentBusiness.identifier" />
     </div>
   </div>
 </template>
@@ -100,25 +102,15 @@ import type { DocumentI } from '~/interfaces/document-i'
 import { BusinessStateE } from '~/enums/business-state-e'
 import { fetchDocuments, saveBlob } from '~/utils/download-file'
 
-const { currentBusiness } = storeToRefs(useBcrosBusiness())
+const { currentBusiness, isFirm } = storeToRefs(useBcrosBusiness())
 const { getStoredFlag } = useBcrosLaunchdarkly()
-const { isAllowedToFile } = useBcrosBusiness()
-const { isFirm } = storeToRefs(useBcrosBusiness())
+const { isAllowedToFile, isDisableNonBenCorps } = useBcrosBusiness()
 
-const enableNonBenCorpsFlag = computed(() => getStoredFlag('enable-non-ben-corps'))
 const isAllowedBusinessSummary = computed(() =>
   currentBusiness.value.identifier &&
   !!getStoredFlag('supported-business-summary-entities')?.includes(currentBusiness.value.legalType)
 )
 
-const isDisableNonBenCorps = computed(() => {
-  if ([CorpTypeCd.BENEFIT_COMPANY, CorpTypeCd.BC_ULC_COMPANY, CorpTypeCd.BC_CCC]
-    .includes(currentBusiness.value.legalType)) {
-    return !enableNonBenCorpsFlag
-  }
-  return false
-})
-
 const isPendingDissolution = computed(() => {
   return false
   // todo: implement !!FUTURE not implemented in current dashboard