Skip to content

Commit

Permalink
- misc import style cleanup
Browse files Browse the repository at this point in the history
- now import CorpTypeCd from module (not enums/)
- added missing import to interfaces package.json
  • Loading branch information
severinbeauvais committed Nov 16, 2023
1 parent dabdd14 commit 3b3d869
Show file tree
Hide file tree
Showing 12 changed files with 21 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/components/completing-party/CompletingParty.vue
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
<script lang="ts">
import Vue from 'vue'
import { Component, Emit, Prop, Watch } from 'vue-property-decorator'
import { AddressIF, CompletingPartyIF, FormIF } from '@bcrs-shared-components/interfaces/'
import { AddressIF, CompletingPartyIF, FormIF } from '@bcrs-shared-components/interfaces'
import BaseAddress from '@bcrs-shared-components/base-address/BaseAddress.vue'
import { isEqual } from 'lodash'
Expand Down
4 changes: 2 additions & 2 deletions src/components/correct-name/CorrectNameRequest.vue
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ import { Component, Emit, Mixins, Prop, Watch } from 'vue-property-decorator'
import { ConfirmDialog as ConfirmDialogShared } from '@bcrs-shared-components/confirm-dialog'
import { NameRequestMixin } from '@bcrs-shared-components/mixins'
import { ConfirmDialogType, NameRequestIF } from '@bcrs-shared-components/interfaces'
import { CorpTypeCd, CorrectNameOptions } from '@bcrs-shared-components/enums'
import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
import { CorrectNameOptions } from '@bcrs-shared-components/enums'
import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
@Component({
components: {
Expand Down
3 changes: 2 additions & 1 deletion src/components/correct-name/CorrectNameToNumber.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
<script lang="ts">
import Vue from 'vue'
import { Component, Prop, Watch, Emit } from 'vue-property-decorator'
import { CorpTypeCd, CorrectNameOptions } from '@bcrs-shared-components/enums'
import { CorrectNameOptions } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
@Component({})
export default class CorrectNameToNumber extends Vue {
Expand Down
5 changes: 3 additions & 2 deletions src/components/fee-summary/FeeSummary.stories.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import type { Meta } from '@storybook/vue'
import Vue from 'vue'
import { FeeSummary } from './index'
import { FilingCodes, CorpTypeCd } from '@bcrs-shared-components/enums/'
import { FilingDataIF } from '@bcrs-shared-components/interfaces/'
import { FilingCodes } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
import { FilingDataIF } from '@bcrs-shared-components/interfaces'

// for SbcFeeSummary
Vue.filter('currency', x => `$${x}`)
Expand Down
4 changes: 2 additions & 2 deletions src/components/fee-summary/SbcFeeSummary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@

<script lang="ts">
import { Vue, Component, Prop, Watch, Emit } from 'vue-property-decorator'
import { FeeServices } from '@bcrs-shared-components/services/'
import { Fee, FilingData } from '@bcrs-shared-components/interfaces/'
import { FeeServices } from '@bcrs-shared-components/services'
import { Fee, FilingData } from '@bcrs-shared-components/interfaces'
@Component({})
export default class SbcFeeSummary extends Vue {
Expand Down
1 change: 1 addition & 0 deletions src/enums/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ export * from './staff-payment-options'
export * from './relationship-types'

// export the enums from corp type module
// DEPRECATED: stop this -- import from corp-type-module instead
export { CorpTypeCd, CorpClass } from '@bcrs-shared-components/corp-type-module'
2 changes: 1 addition & 1 deletion src/interfaces/business-interface.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CorpTypeCd } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'

/**
* A filing's business object from the API. See:
Expand Down
3 changes: 2 additions & 1 deletion src/interfaces/business-lookup-interfaces.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { CorpTypeCd, EntityStates } from '@bcrs-shared-components/enums'
import { EntityStates } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'

export interface BusinessLookupIF {
identifier: string
Expand Down
3 changes: 2 additions & 1 deletion src/interfaces/filing-data-interface.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { CorpTypeCd, FilingCodes } from '@bcrs-shared-components/enums'
import { FilingCodes } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'

/** Filing data object passed to the SBC Fee Summary. */
export interface FilingDataIF {
Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/name-request-interfaces.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { CorpTypeCd, NameRequestStates, NrRequestActionCodes, NrRequestTypeCodes }
from '@bcrs-shared-components/enums'
import { NameRequestStates, NrRequestActionCodes, NrRequestTypeCodes } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
import { AddressIF } from './addresses-interface'
import { ApiDateTimeUtc } from './date-interfaces'

Expand Down
1 change: 1 addition & 0 deletions src/interfaces/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"access": "public"
},
"dependencies": {
"@bcrs-shared-components/corp-type-module": "^1.0.13",
"@bcrs-shared-components/enums": "^1.0.51",
"vue": "^2.7.14"
}
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/CorrectNameToNumber.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import Vuetify from 'vuetify'
import flushPromises from 'flush-promises'
import { mount, Wrapper } from '@vue/test-utils'
import CorrectNameToNumber from '@/components/correct-name/CorrectNameToNumber.vue'
import { CorpTypeCd, CorrectNameOptions } from '@bcrs-shared-components/enums'
import { CorrectNameOptions } from '@bcrs-shared-components/enums'
import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'

const vuetify = new Vuetify({})

Expand Down

0 comments on commit 3b3d869

Please sign in to comment.