allow file upload process to create new version of file if it exists #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimCsaky
requested review from
jatindersingh93 and
norrisng-bc
as code owners
Coverage Report (Application)
|
Coverage Report (Frontend)
|
norrisng-bc
reviewed
Dec 7, 2024
| file, | ||
| { metadata: data?.metadata }, | ||
| { bucketId: bucketId, tagset: data?.tagset }, | ||
| { timeout: 0 } // Infinite timeout for big files upload to avoid timeout error | ||
| ); | ||
|
|
||
| // show toast for any object updates | ||
| if (response?.newVersionId) toast.info(`New version created for ${file.name}`,''); |
There was a problem hiding this comment.
I'd probably mention something along the lines of "Previously deleted file {filename}found. This has been overwritten by the latest upload".
Definitely needs a bit of wordsmithing, but the idea is that if the previously soft-deleted file isn't visible anywhere inside BCBox, it could cause user confusion if we're all of a sudden implying that it already exists.
TimCsaky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allow file upload process to create new version of file if it exists