UI - hosts,strata,examiner applications table updates #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kial Jinnah <[email protected]>
|
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-455-yihqah62.web.app |
|
Temporary Url for review: https://strr-hosts-dev--pr-455-ynw2tbjm.web.app |
deetz99
reviewed
Jan 14, 2025
| 'application-list-resp', | ||
| getApplicationList, | ||
| { | ||
| watch: [limit, page], |
There was a problem hiding this comment.
not really an issue but we could use transform here to clean things up a bit
There was a problem hiding this comment.
I'll keep it as is for now since its likely to change a bit with further reqs. Host / strata need the extra mapping for the local sorting (temporary till its available via the api)
deetz99
reviewed
Jan 14, 2025
deetz99
approved these changes
Jan 14, 2025
dimak1
approved these changes
Jan 14, 2025
| const localePath = useLocalePath() | ||
| const { t } = useI18n() | ||
| const { loading } = storeToRefs(useConnectDetailsHeaderStore()) | ||
| // TODO: ApplicationStatus.FULL_REVIEW is temporary until we have reqs defined | ||
| const { limit, page, getApplicationList } = useStrrBasePermitList(undefined, ApplicationStatus.FULL_REVIEW) |
There was a problem hiding this comment.
We probably will need to pass a few statuses here, eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License