Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host/Strata - UI: Validate upload docs #435

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 6, 2025

Issue:

Description of changes:

  • validate documents for file type and file size before uploading (using 'accept' attribute can be bypassed on windows, maybe mac too but not sure)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

Copy link

sonarqubecloud bot commented Jan 6, 2025

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-435-gml7atyl.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-435-ads2q2hw.web.app

@deetz99 deetz99 changed the title Validate upload docs Host/Strata - UI: Validate upload docs Jan 6, 2025
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me 👍

  • we should fix the ci over the base web at some point

@deetz99
Copy link
Collaborator Author

deetz99 commented Jan 6, 2025

Nice work, looks good to me 👍

  • we should fix the ci over the base web at some point

Yes agreed

@deetz99 deetz99 merged commit c370afb into bcgov:main Jan 6, 2025
33 of 34 checks passed
@deetz99 deetz99 deleted the validate-upload-docs branch January 6, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants