Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strata - UI: document upload optional #428

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 3, 2025

Issue:

Description of changes:

  • make document upload in strata form optional
  • navigate from /dashboard/:id --> /dashboard when user changes accounts in strata and host

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@deetz99 deetz99 requested review from thorwolpert and dimak1 January 3, 2025 18:18
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-428-x142lwoq.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-428-y4mzlhr8.web.app

Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-428-y4mzlhr8.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-428-x142lwoq.web.app

Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was a quick turnaround on the tix, thanks!

@deetz99 deetz99 merged commit 7118f87 into bcgov:main Jan 3, 2025
24 of 25 checks passed
@deetz99 deetz99 deleted the strata-doc-optional branch January 3, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants