Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strata - UI: playwright e2e test #422

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Dec 30, 2024

Issue:

Description of changes:

Screen.Recording.2024-12-30.at.1.38.52.PM.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint only

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util in base layer, dont need to test in platform dir

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test was failing in ui mode, updating is passing now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not need index page

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-422-yx226r9a.web.app

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was causing an issue with vue router and resulted in a 404 in the playwright test, moved page to match file based routing instead

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-422-bjoo3jpc.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-422-mid0lghz.web.app

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main test file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty pdf to use in test file uploader

Copy link
Contributor

@ser-popov ser-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great .. amazing work as always @deetz99

@deetz99 deetz99 merged commit 568aed7 into bcgov:main Dec 31, 2024
24 of 25 checks passed
@deetz99 deetz99 deleted the strata-e2e-test branch December 31, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants